linux-kernel - Re: [PATCH v1 0/2] Rust enablement for LoongArch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sun, 14 Jan 2024 16:43:46 +0100
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: WANG Rui <wangrui@...ngson.cn>
Cc: Boqun Feng <boqun.feng@...il.com>, Miguel Ojeda <ojeda@...nel.org>, 
	Alex Gaynor <alex.gaynor@...il.com>, Wedson Almeida Filho <wedsonaf@...il.com>, 
	Huacai Chen <chenhuacai@...nel.org>, Jonathan Corbet <corbet@....net>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...sung.com>, 
	Alice Ryhl <aliceryhl@...gle.com>, WANG Xuerui <kernel@...0n.name>, rust-for-linux@...r.kernel.org, 
	linux-kernel@...r.kernel.org, loongarch@...ts.linux.dev, 
	linux-doc@...r.kernel.org, loongson-kernel@...ts.loongnix.cn
Subject: Re: [PATCH v1 0/2] Rust enablement for LoongArch

On Thu, Jan 11, 2024 at 4:16 AM WANG Rui <wangrui@...ngson.cn> wrote:
>
> 6.8

Thanks, that is quite expedited...

Please `rustfmt` the code to avoid failing the `rustfmtcheck` target.
I see you already created the 6.8 tag but I have not seen it in
linux-next yet and you did not send the PR, so it would be ideal if
you could fix this before it goes to Linus.

diff --git a/scripts/generate_rust_target.rs b/scripts/generate_rust_targetrs
index 3edda6a10..0da52b548 100644
--- a/scripts/generate_rust_target.rs
+++ b/scripts/generate_rust_target.rs
@@ -163,10 +163,7 @@ fn main() {
         ts.push("target-pointer-width", "64");
     } else if cfg.has("LOONGARCH") {
         ts.push("arch", "loongarch64");
-        ts.push(
-            "data-layout",
-            "e-m:e-p:64:64-i64:64-i128:128-n64-S128",
-        );
+        ts.push("data-layout", "e-m:e-p:64:64-i64:64-i128:128-n64-S128");
         ts.push("features", "-f,-d");
         ts.push("llvm-target", "loongarch64-linux-gnusf");
         ts.push("llvm-abiname", "lp64s");

Thanks!

Cheers,
Miguel