linux-kernel - Re: [PATCH AUTOSEL 4.14 3/6] pinctrl: amd: Mask non-wake source pins with interrupt enabled at suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZaQvGNNPpgZ5VCfa@sashalap>
Date: Sun, 14 Jan 2024 13:59:36 -0500
From: Sasha Levin <sashal@...nel.org>
To: Pavel Machek <pavel@....cz>
Cc: linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	Mario Limonciello <mario.limonciello@....com>,
	Marcus Aram <marcus+oss@...r.nl>,
	Mark Herbert <mark.herbert42@...il.com>,
	Linus Walleij <linus.walleij@...aro.org>, Basavaraj.Natikar@....com,
	Shyam-sundar.S-k@....com, linux-gpio@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 4.14 3/6] pinctrl: amd: Mask non-wake source pins
 with interrupt enabled at suspend

On Tue, Jan 09, 2024 at 12:43:27PM +0100, Pavel Machek wrote:
>Hi!
>
>> From: Mario Limonciello <mario.limonciello@....com>
>>
>> [ Upstream commit 2fff0b5e1a6b9c577b4dd4958902c877159c856b ]
>>
>> If a pin isn't marked as a wake source processing any interrupts is
>> just going to destroy battery life.  The APU may wake up from a hardware
>> sleep state to process the interrupt but not return control to the OS.
>>
>> Mask interrupt for all non-wake source pins at suspend. They'll be
>> re-enabled at resume.
>
>Not sure what is going on here, but it is queued for 6.6 and 4.14, but
>not for the kernels between them.

Ack, it should have been dropped from 4.14. Thanks!

-- 
Thanks,
Sasha