linux-kernel - Re: [PATCH v3] erofs: fix inconsistent per-file compression format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240114151827.000069d6.zbestahu@gmail.com>
Date: Sun, 14 Jan 2024 15:18:27 +0800
From: Yue Hu <zbestahu@...il.com>
To: Gao Xiang <hsiangkao@...ux.alibaba.com>
Cc: linux-erofs@...ts.ozlabs.org, Yue Hu <huyue2@...lpad.com>,
 bugreport@...sectech.com, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] erofs: fix inconsistent per-file compression format

On Sat, 13 Jan 2024 23:06:02 +0800
Gao Xiang <hsiangkao@...ux.alibaba.com> wrote:

> EROFS can select compression algorithms on a per-file basis, and each
> per-file compression algorithm needs to be marked in the on-disk
> superblock for initialization.
> 
> However, syzkaller can generate inconsistent crafted images that use
> an unsupported algorithmtype for specific inodes, e.g. use MicroLZMA
> algorithmtype even it's not set in `sbi->available_compr_algs`.  This
> can lead to an unexpected "BUG: kernel NULL pointer dereference" if
> the corresponding decompressor isn't built-in.
> 
> Fix this by checking against `sbi->available_compr_algs` for each
> m_algorithmformat request.  Incorrect !erofs_sb_has_compr_cfgs preset
> bitmap is now fixed together since it was harmless previously.
> 
> Reported-by: <bugreport@...sectech.com>
> Fixes: 8f89926290c4 ("erofs: get compression algorithms directly on mapping")
> Fixes: 622ceaddb764 ("erofs: lzma compression support")
> Reviewed-by: Yue Hu <huyue2@...lpad.com>
> Signed-off-by: Gao Xiang <hsiangkao@...ux.alibaba.com>

LGTM.

Reviewed-by: Yue Hu <huyue2@...lpad.com>