linux-kernel - Re: [PATCH v3 0/4] kstrtox: introduce memparse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZaPkz7gU42Eahf4L@smile.fi.intel.com>
Date: Sun, 14 Jan 2024 15:42:39 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Qu Wenruo <quwenruo.btrfs@....com>
Cc: Qu Wenruo <wqu@...e.com>, linux-btrfs@...r.kernel.org,
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	christophe.jaillet@...adoo.fr, David.Laight@...lab.com,
	ddiss@...e.de, geert@...ux-m68k.org
Subject: Re: [PATCH v3 0/4] kstrtox: introduce memparse_safe()

On Sun, Jan 07, 2024 at 07:28:27AM +1030, Qu Wenruo wrote:
> On 2024/1/7 01:04, Andy Shevchenko wrote:
> > On Thu, Jan 04, 2024 at 09:57:47AM +1030, Qu Wenruo wrote:

..

> > Having test cases is quite good, thanks!
> > But as I understood what Alexey wanted, is not using the kstrtox files for this.
> > You can introduce it in the cmdline.c, correct? Just include local "kstrtox.h".
> 
> Not really possible, all the needed parsing helpers are internal inside
> kstrtox.c.

I'm not sure I follow. The functions are available to other library (built-in)
modules.

> Furthermore, this also means memparse() can not be enhanced due to:
> 
> - Lack of ways to return errors

What does this mean?

> - Unable to call the parsing helpers inside cmdline.c

??? (see above)

-- 
With Best Regards,
Andy Shevchenko