linux-kernel - [PATCH] nvme/auth: optimize code redundancy and provide code quality

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240115065231.12733-1-mengfanhui@kylinos.cn>
Date: Mon, 15 Jan 2024 14:52:31 +0800
From: mengfanhui <mengfanhui@...inos.cn>
To: kbusch@...nel.org,
	axboe@...nel.dk
Cc: mengfanhui@...inos.cn,
	linux-kernel@...r.kernel.org,
	linux-nvme@...ts.infradead.org,
	sagi@...mberg.me
Subject: [PATCH] nvme/auth: optimize code redundancy and provide code quality

Improve code quality. Reduce code redundancy.

Signed-off-by: mengfanhui <mengfanhui@...inos.cn>
---
 drivers/nvme/common/auth.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/nvme/common/auth.c b/drivers/nvme/common/auth.c
index a23ab5c968b9..4f9d06afdc38 100644
--- a/drivers/nvme/common/auth.c
+++ b/drivers/nvme/common/auth.c
@@ -250,9 +250,7 @@ struct nvme_dhchap_key *nvme_auth_transform_key(
 	if (key->hash == 0) {
 		key_len = nvme_auth_key_struct_size(key->len);
 		transformed_key = kmemdup(key, key_len, GFP_KERNEL);
-		if (!transformed_key)
-			return ERR_PTR(-ENOMEM);
-		return transformed_key;
+		return transformed_key ? transformed_key : ERR_PTR(-ENOMEM);
 	}
 	hmac_name = nvme_auth_hmac_name(key->hash);
 	if (!hmac_name) {

base-commit: c29901006179c4c87f9335771e50814ec5707239
-- 
2.25.1