linux-kernel - Re: [PATCH] sched/eevdf: using leftmost improves the readability of the code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <61ba46217934e70f14e84b7b3e467c033854b6c3.camel@gmx.de>
Date: Mon, 15 Jan 2024 08:41:22 +0100
From: Mike Galbraith <efault@....de>
To: Liu Song <liusong@...ux.alibaba.com>, mingo@...hat.com, 
	peterz@...radead.org
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sched/eevdf: using leftmost improves the readability of
 the code

On Mon, 2024-01-15 at 12:46 +0800, Liu Song wrote:
> Using 'leftmost' enhances code readability..

Not even a little bit, it's already blatantly obvious at a glance.

> Signed-off-by: Liu Song <liusong@...ux.alibaba.com>
> ---
>  kernel/sched/fair.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index f2bb83675e4a..4247584258ae 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -848,12 +848,12 @@ struct sched_entity *__pick_root_entity(struct cfs_rq *cfs_rq)
>  
>  struct sched_entity *__pick_first_entity(struct cfs_rq *cfs_rq)
>  {
> -       struct rb_node *left = rb_first_cached(&cfs_rq->tasks_timeline);
> +       struct rb_node *leftmost = rb_first_cached(&cfs_rq->tasks_timeline);
>  
> -       if (!left)
> +       if (!leftmost)
>                 return NULL;
>  
> -       return __node_2_se(left);
> +       return __node_2_se(leftmost);
>  }
>  
>  /*