linux-kernel - Re: [PATCH 2/4] usb: ucsi: Add quirk infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZaTkaf/OmhvEr7ZI@kuha.fi.intel.com>
Date: Mon, 15 Jan 2024 09:53:13 +0200
From: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To: "Christian A. Ehrhardt" <lk@...e.de>
Cc: linux-usb@...r.kernel.org, Dell.Client.Kernel@...l.com,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Neil Armstrong <neil.armstrong@...aro.org>,
	Hans de Goede <hdegoede@...hat.com>,
	Jack Pham <quic_jackp@...cinc.com>,
	Fabrice Gasnier <fabrice.gasnier@...s.st.com>,
	Samuel Čavoj <samuel@...oj.net>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] usb: ucsi: Add quirk infrastructure

On Sun, Jan 07, 2024 at 01:16:59AM +0100, Christian A. Ehrhardt wrote:
> Allow bus drivers to specify quirks for the UCSI core on
> attach. Allow the user to override the quirks on the command
> line.
> 
> Signed-off-by: Christian A. Ehrhardt <lk@...e.de>
> ---
>  Documentation/admin-guide/kernel-parameters.txt |  5 +++++
>  drivers/usb/typec/ucsi/ucsi.c                   | 12 +++++++++++-
>  drivers/usb/typec/ucsi/ucsi.h                   |  6 +++++-
>  drivers/usb/typec/ucsi/ucsi_acpi.c              |  2 +-
>  drivers/usb/typec/ucsi/ucsi_ccg.c               |  2 +-
>  drivers/usb/typec/ucsi/ucsi_glink.c             |  2 +-
>  drivers/usb/typec/ucsi/ucsi_stm32g0.c           |  2 +-
>  7 files changed, 25 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index 0a6a4b7f7a3b..fd8152dd4450 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -6783,6 +6783,11 @@
>  			<port#>,<js1>,<js2>,<js3>,<js4>,<js5>,<js6>,<js7>
>  			See also Documentation/input/devices/joystick-parport.rst
>  
> +	typec_ucsi.quirks=	[USB]
> +			A hex value specifying the quirks to enable for
> +			the USB Type-C connector system software interface
> +			driver. This overrides auto detected quirks.

New module parameters are not going to be accepted.

Please just fix the issue with Dell's first like I proposed, and then
you can start thinking about the infra for the quirks.

thanks,


-- 
heikki