linux-kernel - Re: [PATCH] ARM: zynq: slcr: fix function prototype kernel-doc warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 15 Jan 2024 09:12:44 +0100
From: Michal Simek <michal.simek@....com>
To: Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org
Cc: Russell King <linux@...linux.org.uk>,
 linux-arm-kernel@...ts.infradead.org, patches@...linux.org.uk
Subject: Re: [PATCH] ARM: zynq: slcr: fix function prototype kernel-doc
 warnings



On 1/14/24 06:17, Randy Dunlap wrote:
> Use the same name in the function prototype description and the function
> to prevent kernel-doc warnings:
> 
> slcr.c:158: warning: expecting prototype for zynq_slcr_cpu_state(). Prototype was for zynq_slcr_cpu_state_read() instead
> slcr.c:176: warning: expecting prototype for zynq_slcr_cpu_state(). Prototype was for zynq_slcr_cpu_state_write() instead
> 
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Michal Simek <michal.simek@....com>
> Cc: Russell King <linux@...linux.org.uk>
> Cc: linux-arm-kernel@...ts.infradead.org
> Cc: patches@...linux.org.uk
> ---
> KernelVersion: 0dd3ee31125508cd67f7e717
> 
>   arch/arm/mach-zynq/slcr.c |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff -- a/arch/arm/mach-zynq/slcr.c b/arch/arm/mach-zynq/slcr.c
> --- a/arch/arm/mach-zynq/slcr.c
> +++ b/arch/arm/mach-zynq/slcr.c
> @@ -146,7 +146,7 @@ void zynq_slcr_cpu_stop(int cpu)
>   }
>   
>   /**
> - * zynq_slcr_cpu_state - Read/write cpu state
> + * zynq_slcr_cpu_state_read - Read cpu state
>    * @cpu:	cpu number
>    *
>    * SLCR_REBOOT_STATUS save upper 2 bits (31/30 cpu states for cpu0 and cpu1)
> @@ -165,7 +165,7 @@ bool zynq_slcr_cpu_state_read(int cpu)
>   }
>   
>   /**
> - * zynq_slcr_cpu_state - Read/write cpu state
> + * zynq_slcr_cpu_state_write - Write cpu state
>    * @cpu:	cpu number
>    * @die:	cpu state - true if cpu is going to die
>    *


Applied.
Thanks,
Michal