linux-kernel - Re: [PATCH v12 2/3] dt-bindings: hwmon: Support Aspeed g6 PWM TACH Control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <OSQPR06MB72520BD77D68B7940273F2498B6C2@OSQPR06MB7252.apcprd06.prod.outlook.com>
Date: Mon, 15 Jan 2024 08:43:09 +0000
From: Billy Tsai <billy_tsai@...eedtech.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, Rob Herring
	<robh@...nel.org>
CC: "jdelvare@...e.com" <jdelvare@...e.com>, "linux@...ck-us.net"
	<linux@...ck-us.net>, "krzysztof.kozlowski+dt@...aro.org"
	<krzysztof.kozlowski+dt@...aro.org>, "joel@....id.au" <joel@....id.au>,
	"andrew@...id.au" <andrew@...id.au>, "corbet@....net" <corbet@....net>,
	"thierry.reding@...il.com" <thierry.reding@...il.com>,
	"u.kleine-koenig@...gutronix.de" <u.kleine-koenig@...gutronix.de>,
	"p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
	"naresh.solanki@...ements.com" <naresh.solanki@...ements.com>,
	"linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-aspeed@...ts.ozlabs.org"
	<linux-aspeed@...ts.ozlabs.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-doc@...r.kernel.org"
	<linux-doc@...r.kernel.org>, "linux-pwm@...r.kernel.org"
	<linux-pwm@...r.kernel.org>, BMC-SW <BMC-SW@...eedtech.com>,
	"patrick@...cx.xyz" <patrick@...cx.xyz>
Subject: Re: [PATCH v12 2/3] dt-bindings: hwmon: Support Aspeed g6 PWM TACH
 Control

> >>> +examples:
> >>> +  - |
> >>> +    #include <dt-bindings/clock/aspeed-clock.h>
> >>> +    pwm_tach: pwm-tach-controller@...10000 {
> >>> +      compatible = "aspeed,ast2600-pwm-tach";
> >>> +      reg = <0x1e610000 0x100>;
> >>> +      clocks = <&syscon ASPEED_CLK_AHB>;
> >>> +      resets = <&syscon ASPEED_RESET_PWM>;
> >>> +      #pwm-cells = <3>;
> >>> +
> >>> +      fan-0 {
> >>> +        tach-ch = /bits/ 8 <0x0>;
> >>> +      };
> >>> +
> >>> +      fan-1 {
> >>> +        tach-ch = /bits/ 8 <0x1 0x2>;
> >>> +      };
> >
> >> NAK on this based on how you are using pwm-fan in v10 discussion. See my
> >> comments there.
> >
> > Okay, I will merge everything from the pwm-fan0 node into the fan-0 node
> > and add the 'simple-bus' to the compatible string of the pwm_tach node.

> What simple-bus has anything to do with it? This is not a bus. Just to
> remind: we talk about bindings, not driver.

Hi Krzysztof,

If I want to create a dt-binding to indicate that the child nodes
should be treated as platform devices, which will be probed based on the
compatible string, can I add "simple-bus" for our pwm_tach node like the
following?
pwm_tach: pwm-tach-controller@...10000 {
        compatible = "aspeed,ast2600-pwm-tach", "simple-bus";
        reg = <0x1e610000 0x100>;
        clocks = <&syscon ASPEED_CLK_AHB>;
        resets = <&syscon ASPEED_RESET_PWM>;
        #pwm-cells = <3>;
  
        fan-0 {
          tach-ch = /bits/ 8 <0x0>;
          compatible = "pwm-fan";
          pwms = <&pwm_tach 0 40000 0>;
        };
  
        fan-1 {
          tach-ch = /bits/ 8 <0x1 0x2>;
          compatible = "pwm-fan";
          pwms = <&pwm_tach 1 40000 0>;
        };
      };
Or do you have any other suggestions for describing this in the dt-bindings?

Thanks

Billy Tsai.