linux-kernel - Re: [PATCH] gpio: rtd: Fix signedness bug in probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMRc=McCVRNpWjifPC=LTW7icF9SkbaQ9jEryM=TcHFy-tQ7dQ@mail.gmail.com>
Date: Mon, 15 Jan 2024 11:08:12 +0100
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Tzuyi Chang <tychang@...ltek.com>, Linus Walleij <linus.walleij@...aro.org>, 
	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org, 
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] gpio: rtd: Fix signedness bug in probe

On Fri, Jan 12, 2024 at 7:55 AM Dan Carpenter <dan.carpenter@...aroorg> wrote:
>
> The "data->irqs[]" array holds unsigned int so this error handling will
> not work correctly.
>
> Fixes: eee636bff0dc ("gpio: rtd: Add support for Realtek DHC(Digital Home Center) RTD SoCs")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>  drivers/gpio/gpio-rtd.c | 15 +++++++++------
>  1 file changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpio/gpio-rtd.c b/drivers/gpio/gpio-rtd.c
> index a7939bd0aa56..bf7f008f58d7 100644
> --- a/drivers/gpio/gpio-rtd.c
> +++ b/drivers/gpio/gpio-rtd.c
> @@ -525,18 +525,21 @@ static int rtd_gpio_probe(struct platform_device *pdev)
>         struct device *dev = &pdev->dev;
>         struct gpio_irq_chip *irq_chip;
>         struct rtd_gpio *data;
> +       int ret;
>
>         data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
>         if (!data)
>                 return -ENOMEM;
>
> -       data->irqs[0] = platform_get_irq(pdev, 0);
> -       if (data->irqs[0] < 0)
> -               return data->irqs[0];
> +       ret = platform_get_irq(pdev, 0);
> +       if (ret < 0)
> +               return ret;
> +       data->irqs[0] = ret;
>
> -       data->irqs[1] = platform_get_irq(pdev, 1);
> -       if (data->irqs[1] < 0)
> -               return data->irqs[1];
> +       ret = platform_get_irq(pdev, 1);
> +       if (ret < 0)
> +               return ret;
> +       data->irqs[1] = ret;
>
>         data->info = device_get_match_data(dev);
>         if (!data->info)
> --
> 2.43.0
>

Applied, thanks!

Bartosz