linux-kernel - Re: [PATCH] dt-bindings: usb: add common Type-C USB Switch schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4c819e89-80d9-442f-af82-4b3d084ab9df@linaro.org>
Date: Mon, 15 Jan 2024 12:36:46 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Luca Weiss <luca.weiss@...rphone.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konrad.dybcio@...aro.org>,
 Neil Armstrong <neil.armstrong@...aro.org>, linux-usb@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: usb: add common Type-C USB Switch schema

On 15/01/2024 10:34, Luca Weiss wrote:
>> diff --git a/Documentation/devicetree/bindings/usb/usb-switch.yaml b/Documentation/devicetree/bindings/usb/usb-switch.yaml
>> new file mode 100644
>> index 000000000000..0d0b60234d1f
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/usb/usb-switch.yaml
>> @@ -0,0 +1,68 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/usb/usb-switch.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: USB Orientation and Mode Switches Common Properties
>> +
>> +maintainers:
>> +  - Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>> +
>> +description:
>> +  Common properties for devices handling USB mode and orientation switching.
>> +
>> +properties:
>> +  mode-switch:
>> +    description: Possible handle of altmode switching
> 
> handle -> handler

ack

> 
>> +    type: boolean
>> +
>> +  orientation-switch:
>> +    description: Possible handler of orientation switching
>> +    type: boolean
>> +
>> +  retimer-switch:
>> +    description: Possible handle of SuperSpeed signals retiming
> 
> handle -> handler

ack

> 
>> +    type: boolean
>> +
>> +  port:
>> +    $ref: /schemas/graph.yaml#/properties/port
>> +    description:
>> +      A port node to link the device to a TypeC controller for the purpose of
>> +      handling altmode muxing and orientation switching.
>> +
>> +  ports:
>> +    $ref: /schemas/graph.yaml#/properties/ports
>> +    properties:
>> +      port@0:
>> +        $ref: /schemas/graph.yaml#/properties/port
>> +        description:
>> +          Super Speed (SS) Output endpoint to the Type-C connector
>> +
>> +      port@1:
>> +        $ref: /schemas/graph.yaml#/$defs/port-base
>> +        description:
>> +          Super Speed (SS) Input endpoint from the Super-Speed PHY
>> +        unevaluatedProperties: false
>> +
>> +        properties:
>> +          endpoint:
>> +            $ref: /schemas/graph.yaml#/$defs/endpoint-base
>> +            # additionalProperties: true
> 
> Don't think this should still be here?
> 

Indeed, debug left-over. I'll remove it.

Best regards,
Krzysztof