linux-kernel - Re: [PATCH 4/4] usb: ucsi: Apply UCSI_ACK_CONNECTOR_CHANGE_ACK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZaUdowRhVjAxAIM+@cae.in-ulm.de>
Date: Mon, 15 Jan 2024 12:57:23 +0100
From: "Christian A. Ehrhardt" <lk@...e.de>
To: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Cc: linux-usb@...r.kernel.org, Dell.Client.Kernel@...l.com,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Neil Armstrong <neil.armstrong@...aro.org>,
	Hans de Goede <hdegoede@...hat.com>,
	Jack Pham <quic_jackp@...cinc.com>,
	Fabrice Gasnier <fabrice.gasnier@...s.st.com>,
	Samuel Čavoj <samuel@...oj.net>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] usb: ucsi: Apply UCSI_ACK_CONNECTOR_CHANGE_ACK_CMD
 to Dell systems


Hi Heikki,

On Mon, Jan 15, 2024 at 11:05:36AM +0200, Heikki Krogerus wrote:
> Hi Christian,
> 
> On Sun, Jan 07, 2024 at 01:17:01AM +0100, Christian A. Ehrhardt wrote:
> > Apply the UCSI_ACK_CONNECTOR_CHANGE_ACK_CMD to all Dell systems.
> > 
> > There are various reports that ucsi does not work on Dell systems
> > with "GET_CONNECTOR_STATUS failed". At least some of these are
> > most likely due to the need for this quirk.
> > 
> > If the logic is wrong users can still use the new quirk override
> > for the typec_ucsi module to disable the quirk.
> > 
> > Signed-off-by: Christian A. Ehrhardt <lk@...e.de>
> > ---
> >  drivers/usb/typec/ucsi/ucsi_acpi.c | 36 +++++++++++++++++++++++++-----
> >  1 file changed, 31 insertions(+), 5 deletions(-)
> > 
> > diff --git a/drivers/usb/typec/ucsi/ucsi_acpi.c b/drivers/usb/typec/ucsi/ucsi_acpi.c
> > index 78a0d13584ad..690d5e55bdc4 100644
> > --- a/drivers/usb/typec/ucsi/ucsi_acpi.c
> > +++ b/drivers/usb/typec/ucsi/ucsi_acpi.c
> > @@ -27,6 +27,11 @@ struct ucsi_acpi {
> >  	u64 cmd;
> >  };
> >  
> > +struct ucsi_acpi_attach_data {
> > +	const struct ucsi_operations *ops;
> > +	unsigned int quirks;
> > +};
> > +
> >  static int ucsi_acpi_dsm(struct ucsi_acpi *ua, int func)
> >  {
> >  	union acpi_object *obj;
> > @@ -121,12 +126,30 @@ static const struct ucsi_operations ucsi_zenbook_ops = {
> >  	.async_write = ucsi_acpi_async_write
> >  };
> >  
> > -static const struct dmi_system_id zenbook_dmi_id[] = {
> > +static const struct ucsi_acpi_attach_data ucsi_acpi_default_attach_data = {
> > +	.ops = &ucsi_acpi_ops,
> > +	.quirks = 0
> > +};
> > +
> > +static const struct dmi_system_id ucsi_acpi_quirks[] = {
> >  	{
> >  		.matches = {
> >  			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> >  			DMI_MATCH(DMI_PRODUCT_NAME, "ZenBook UX325UA_UM325UA"),
> >  		},
> > +		.driver_data = &(struct ucsi_acpi_attach_data) {
> > +			.ops = &ucsi_zenbook_ops,
> > +			.quirks = 0
> > +		},
> > +	},
> > +	{
> > +		.matches = {
> > +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> > +		},
> > +		.driver_data = &(struct ucsi_acpi_attach_data) {
> > +			.ops = &ucsi_acpi_ops,
> > +			.quirks = UCSI_ACK_CONNECTOR_CHANGE_ACK_CMD
> 
> Please don't add any more quirk flags like that for single user (you
> may never have more than the one user for it). Let's just first handle
> this with only Dell's like I proposed.
> 
> If there are other platforms that need the same quirk, then we can
> start looking at how to share the quirk.

Ok, thanks for the feedback. Will do.

However, please note that it is not clear if it is all or only some
dells that need this. This is the prime reason why I was looking for
a way to enable/disable the quirk.

     regards   Christian