linux-kernel - Re: [PATCH] firmware/arm_sdei: Fix invalid argument to unregister private events.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 15 Jan 2024 14:01:50 +0100
From: Pierre Gondois <pierre.gondois@....com>
To: Levi Yun <ppbuk5246@...il.com>, james.morse@....com
Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] firmware/arm_sdei: Fix invalid argument to unregister
 private events.

Hello Levi,

On 1/10/24 10:01, Levi Yun wrote:
> To unregister private events in device freeze, it should call
> cpuhp_remove_state with sdei_hp_state not sdei_entry_point.
> otherwise, it seems to fail on cpuhp_cb_check.
> 

I think you can also add:
Fixes: d2c48b2387eb ("firmware: arm_sdei: Fix sleep from invalid context BUG")


> Signed-off-by: Levi Yun <ppbuk5246@...il.com>
> ---
>   drivers/firmware/arm_sdei.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/firmware/arm_sdei.c b/drivers/firmware/arm_sdei.c
> index 285fe7ad490d..3e8051fe8296 100644
> --- a/drivers/firmware/arm_sdei.c
> +++ b/drivers/firmware/arm_sdei.c
> @@ -763,7 +763,7 @@ static int sdei_device_freeze(struct device *dev)
>   	int err;
>   
>   	/* unregister private events */
> -	cpuhp_remove_state(sdei_entry_point);
> +	cpuhp_remove_state(sdei_hp_state);

Maybe it would also be worth resetting 'sdei_hp_state':
   sdei_hp_state = 0;

>   
>   	err = sdei_unregister_shared();
>   	if (err)

Regards,
Pierre