linux-kernel - Re: [PATCH] dt-bindings: rockchip: Fix Hardkernel ODROID-M1 board bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 16 Jan 2024 00:48:37 +0900
From: KyuHyuk Lee <lee@...hyuk.kr>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Rob Herring <robh+dt@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Heiko Stuebner <heiko@...ech.de>,
	Chris Morgan <macromorgan@...mail.com>,
	Tianling Shen <cnsztl@...il.com>, Jagan Teki <jagan@...eble.ai>,
	Ondrej Jirman <megi@....cz>, Andy Yan <andyshrk@....com>,
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: rockchip: Fix Hardkernel ODROID-M1 board
 bindings

On Mon, Jan 15, 2024 at 03:58:56PM +0100, Krzysztof Kozlowski wrote:
> On 15/01/2024 15:51, KyuHyuk Lee wrote:
> > The vendor in ODROID-M1 is hardkernel, but it was incorrectly written
> > as rockchip. Fixed the vendor prefix correctly.
> > 
> > Signed-off-by: KyuHyuk Lee <lee@...hyuk.kr>
> > ---
> >  Documentation/devicetree/bindings/arm/rockchip.yaml | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> You need to start testing your patches. Your last M1 fails as well in
> multiple places.
> 
> It does not look like you tested the DTS against bindings. Please run
> `make dtbs_check W=1` (see
> Documentation/devicetree/bindings/writing-schema.rst or
> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
> for instructions).
> 
> The DTS change will break the users, so would be nice to mention this in
> its commit msg.
> 
> Best regards,
> Krzysztof
> 

Hello, Krzysztof.

I am truly sorry for wasting your time due to my mistake.
>From now on, i will carefully send PATCH with testing.
I'm really sorry.

Thank you,
KyuHyuk Lee.