linux-kernel - Re: [PATCH v2] cxl: Fix null pointer dereference in cxl_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <94f35d3f8ad3b8052100594bf78e915beb477a47.camel@linux.ibm.com>
Date: Mon, 15 Jan 2024 16:02:51 +1100
From: Andrew Donnellan <ajd@...ux.ibm.com>
To: Kunwu Chan <chentao@...inos.cn>, fbarrat@...ux.ibm.com, arnd@...db.de,
        mpe@...erman.id.au, mrochs@...ux.vnet.ibm.com
Cc: linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
        Kunwu Chan
	 <kunwu.chan@...mail.com>
Subject: Re: [PATCH v2] cxl: Fix null pointer dereference in cxl_get_fd

On Fri, 2024-01-12 at 13:49 +0800, Kunwu Chan wrote:

> +err:
> +	if (rc < 0)
> +		return ERR_PTR(rc);
>  	return NULL;

I don't think there's a way for this NULL to ever get returned?

Apart from that it looks good:

Reviewed-by: Andrew Donnellan <ajd@...ux.ibm.com>

-- 
Andrew Donnellan    OzLabs, ADL Canberra
ajd@...ux.ibm.com   IBM Australia Limited