linux-kernel - Re: [PATCH] dt-bindings: ignore paths outside kernel for DT_SCHEMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8c5afb4e52e0c5a6dd88f6b7eaa7bc2e97ba31ad.camel@linaro.org>
Date: Mon, 15 Jan 2024 16:57:26 +0000
From: André Draszik <andre.draszik@...aro.org>
To: Michal Simek <michal.simek@....com>, Conor Dooley <conor@...nel.org>
Cc: Rob Herring <robh@...nel.org>, Rob Herring <robh+dt@...nel.org>, 
 Masahiro Yamada <masahiroy@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 Mathieu Poirier <mathieu.poirier@...aro.org>, linux-kernel@...r.kernel.org,
  devicetree@...r.kernel.org, Krzysztof Kozlowski
 <krzysztof.kozlowski+dt@...aro.org>
Subject: Re: [PATCH] dt-bindings: ignore paths outside kernel for
 DT_SCHEMA_FILES

On Mon, 2024-01-15 at 17:37 +0100, Michal Simek wrote:
> 
> 
> On 1/15/24 17:29, Conor Dooley wrote:
> > On Mon, Jan 15, 2024 at 09:40:37AM +0000, André Draszik wrote:
> > > Hi,
> > > 
> > > On Mon, 2024-01-15 at 10:20 +0100, Michal Simek wrote:
> > > > This patch is causing issue for me. Look at log below.
> > > > I am running it directly on the latest linux-next/master.
> > > > 
> > > > Thanks,
> > > > Michal
> > > > 
> > > > $ make DT_SCHEMA_FILES="Documentation/devicetree/bindings/arm/arm,cci-400.yaml"
> > > > dt_binding_check
> > > 
> > > It'll work if you drop the 'Documentation/devicetree/bindings' part from the path, as
> > > it is implied since bindings can only be in that directory anyway:
> > > 
> > >      make DT_SCHEMA_FILES="arm/arm,cci-400.yaml" dt_binding_check
> > >      make DT_SCHEMA_FILES="arm,cci-400.yaml" dt_binding_check
> > > 
> > > both work.
> > 
> > Requiring that is pretty user unfriendly though I think, passing the
> > full path from the root directory of the kernel tree would be my
> > assumption of the "default".
> 
> I am using full path like this for years.

I just just went by Documentation/devicetree/bindings/writing-schema.rst
which doesn't suggest adding Documentation/devicetree/bindings/. In an
attempt to make it more robust for anybody following this doc, I opted
for the current implementation.

> I can fix my scripts but would be good to consider correct path inside the 
> kernel is something what this patch should also allow.
> Because path above is correct and it is not outside of the kernel that's why at 
> least commit message should be massage a little bit.

I hear you, and I'll make a v2 to not imply the bindings directory.



Cheers,
A.