linux-kernel - Re: [PATCH 03/14] i2c: omap: wakeup the controller during suspend callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vcr+pSjj+27WmW5GmC_QvpJu3E81C-GjxqdhrCAByevpQ@mail.gmail.com>
Date: Mon, 15 Jan 2024 22:03:46 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Thomas Richard <thomas.richard@...tlin.com>
Cc: Linus Walleij <linus.walleij@...aro.org>, Bartosz Golaszewski <brgl@...ev.pl>, 
	Andy Shevchenko <andy@...nel.org>, Tony Lindgren <tony@...mide.com>, 
	Haojian Zhuang <haojian.zhuang@...aro.org>, Vignesh R <vigneshr@...com>, 
	Aaro Koskinen <aaro.koskinen@....fi>, Janusz Krzysztofik <jmkrzyszt@...il.com>, 
	Andi Shyti <andi.shyti@...nel.org>, Peter Rosin <peda@...ntia.se>, Vinod Koul <vkoul@...nel.org>, 
	Kishon Vijay Abraham I <kishon@...nel.org>, Philipp Zabel <p.zabel@...gutronix.de>, 
	Tom Joseph <tjoseph@...ence.com>, Lorenzo Pieralisi <lpieralisi@...nel.org>, 
	Krzysztof Wilczyński <kw@...ux.com>, 
	Rob Herring <robh@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>, linux-gpio@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-omap@...r.kernel.org, linux-i2c@...r.kernel.org, 
	linux-phy@...ts.infradead.org, linux-pci@...r.kernel.org, 
	gregory.clement@...tlin.com, theo.lebrun@...tlin.com, 
	thomas.petazzoni@...tlin.com, u-kumar1@...com
Subject: Re: [PATCH 03/14] i2c: omap: wakeup the controller during suspend callback

On Mon, Jan 15, 2024 at 6:16 PM Thomas Richard
<thomas.richard@...tlin.com> wrote:
>
> A device may need the controller up during suspend_noirq or
> resume_noirq.
> But if the controller is autosuspended, there is no way to wakeup it
> during suspend_noirq or resume_noirq because runtime pm is disabled
> at this time.
>
> The suspend callback wakes up the controller, so it is available until
> its suspend_noirq callback (pm_runtime_force_suspend).
> During the resume, it's restored by resume_noirq callback
> (pm_runtime_force_resume). Then resume callback enables autosuspend.
>
> So the controller is up during a little time slot in suspend and resume
> sequences even if it's not used.

Same comment

->...callback...()

..

>  }
>
> +

Stray blank line is added.

> +static int omap_i2c_suspend(struct device *dev)

-- 
With Best Regards,
Andy Shevchenko