linux-kernel - Re: [PATCH] drm/amd/display: Fix a switch statement in populate_dml_output_cfg_from_stream

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d12c2a3e-2a66-4624-b5e9-9921f3359036@amd.com>
Date: Mon, 15 Jan 2024 16:51:52 -0500
From: Hamza Mahfooz <hamza.mahfooz@....com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>,
 Harry Wentland <harry.wentland@....com>, Leo Li <sunpeng.li@....com>,
 Rodrigo Siqueira <Rodrigo.Siqueira@....com>,
 Alex Deucher <alexander.deucher@....com>,
 Christian König <christian.koenig@....com>,
 "Pan, Xinhui" <Xinhui.Pan@....com>, David Airlie <airlied@...il.com>,
 Daniel Vetter <daniel@...ll.ch>, Roman Li <roman.li@....com>,
 Qingqing Zhuo <Qingqing.Zhuo@....com>
Cc: dri-devel@...ts.freedesktop.org, kernel-janitors@...r.kernel.org,
 linux-kernel@...r.kernel.org, amd-gfx@...ts.freedesktop.org
Subject: Re: [PATCH] drm/amd/display: Fix a switch statement in
 populate_dml_output_cfg_from_stream_state()

On 1/13/24 09:58, Christophe JAILLET wrote:
> It is likely that the statement related to 'dml_edp' is misplaced. So move
> it in the correct "case SIGNAL_TYPE_EDP".
> 
> Fixes: 7966f319c66d ("drm/amd/display: Introduce DML2")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Nice catch! Applied, thanks!

> ---
>   drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_helper.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_helper.c b/drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_helper.c
> index fa6a93dd9629..64d01a9cd68c 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_helper.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_helper.c
> @@ -626,8 +626,8 @@ static void populate_dml_output_cfg_from_stream_state(struct dml_output_cfg_st *
>   		if (is_dp2p0_output_encoder(pipe))
>   			out->OutputEncoder[location] = dml_dp2p0;
>   		break;
> -		out->OutputEncoder[location] = dml_edp;
>   	case SIGNAL_TYPE_EDP:
> +		out->OutputEncoder[location] = dml_edp;
>   		break;
>   	case SIGNAL_TYPE_HDMI_TYPE_A:
>   	case SIGNAL_TYPE_DVI_SINGLE_LINK:
-- 
Hamza