linux-kernel - Re: [PATCH] nvme/auth: optimize code redundancy and provide code quality

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a60bf7f7-e520-400a-ae68-73f448f0e3f9@nvidia.com>
Date: Mon, 15 Jan 2024 22:21:30 +0000
From: Chaitanya Kulkarni <chaitanyak@...dia.com>
To: mengfanhui <mengfanhui@...inos.cn>
CC: Sagi Grimberg <sagi@...mberg.me>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "axboe@...nel.dk" <axboe@...nel.dk>,
	"linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
	"kbusch@...nel.org" <kbusch@...nel.org>
Subject: Re: [PATCH] nvme/auth: optimize code redundancy and provide code
 quality


>> +        return transformed_key ? transformed_key : ERR_PTR(-ENOMEM);

I've received many comments about not using ?: in kernel code as
if .. else is preferred way, not sure if this is a good idea

-ck