linux-kernel - Re: [PATCH v2 3/3] dt-bindings: rockchip: Update rk809 example with audio codec properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240116-muppet-buggy-4caf9620b660@spud>
Date: Tue, 16 Jan 2024 17:09:23 +0000
From: Conor Dooley <conor@...nel.org>
To: Tim Lunn <tim@...thertop.org>
Cc: linux-rockchip@...ts.infradead.org, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	Chris Zhong <zyw@...k-chips.com>,
	Conor Dooley <conor+dt@...nel.org>,
	Heiko Stuebner <heiko@...ech.de>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Lee Jones <lee@...nel.org>, Rob Herring <robh+dt@...nel.org>,
	Zhang Qing <zhangqing@...k-chips.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/3] dt-bindings: rockchip: Update rk809 example with
 audio codec properties

On Wed, Jan 17, 2024 at 12:21:02AM +1100, Tim Lunn wrote:
> Update the example provided to include the properties for using
> rk817 audio codec.
> 
> Signed-off-by: Tim Lunn <tim@...thertop.org>
> 
> ---
> 
> Changes in v2:
> - Fix missing include and pinctrl for codec example
> 
>  .../devicetree/bindings/mfd/rockchip,rk809.yaml          | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml b/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml
> index 9b9d670708ce..fee8338b230b 100644
> --- a/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml
> +++ b/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml
> @@ -147,6 +147,7 @@ additionalProperties: false
>  
>  examples:
>    - |
> +    #include <dt-bindings/clock/px30-cru.h>
>      #include <dt-bindings/pinctrl/rockchip.h>
>      #include <dt-bindings/interrupt-controller/irq.h>
>      #include <dt-bindings/gpio/gpio.h>
> @@ -161,10 +162,13 @@ examples:
>              clock-output-names = "xin32k", "rk808-clkout2";
>              interrupt-parent = <&gpio3>;
>              interrupts = <10 IRQ_TYPE_LEVEL_LOW>;
> +            clock-names = "mclk";
> +            clocks = <&cru SCLK_I2S1_OUT>;
>              pinctrl-names = "default";
> -            pinctrl-0 = <&pmic_int_l_pin>;
> +            pinctrl-0 = <&pmic_int_l_pin>, <&i2s1_2ch_mclk>;
>              rockchip,system-power-controller;
>              wakeup-source;
> +            #sound-dai-cells = <0>;
>  
>              vcc1-supply = <&vcc_sysin>;
>              vcc2-supply = <&vcc_sysin>;
> @@ -309,5 +313,8 @@ examples:
>                      };
>                  };
>              };

Blank line here please.
I'd squash this with the patch adding the codec as an allowed property
though.

Thanks,
Conor.

> +            rk817_codec: codec {
> +                rockchip,mic-in-differential;
> +            };
>          };
>      };
> -- 
> 2.40.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)