linux-kernel - Re: [PATCH v22 3/8] arm: dts: nuvoton: npcm7xx: modify rst syscon node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52697bd3-01a6-4522-a0fc-e9e6f027cff2@linaro.org>
Date: Tue, 16 Jan 2024 21:33:02 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Tomer Maimon <tmaimon77@...il.com>
Cc: mturquette@...libre.com, sboyd@...nel.org, robh+dt@...nel.org,
 krzysztof.kozlowski+dt@...aro.org, tali.perry1@...il.com, joel@....id.au,
 venture@...gle.com, yuenn@...gle.com, benjaminfair@...gle.com,
 openbmc@...ts.ozlabs.org, linux-clk@...r.kernel.org,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v22 3/8] arm: dts: nuvoton: npcm7xx: modify rst syscon
 node

On 16/01/2024 20:51, Tomer Maimon wrote:
> Hi Krzysztof,
> 
> Thanks for your comment.
> 
> On Wed, 10 Jan 2024 at 23:01, Krzysztof Kozlowski
> <krzysztof.kozlowski@...aro.org> wrote:
>>
>> On 08/01/2024 14:54, Tomer Maimon wrote:
>>> rst node name and compatible property modified since clock and reset are
>>> handled in the same memory region.
>>>
>>> Signed-off-by: Tomer Maimon <tmaimon77@...il.com>
>>> ---
>>>  arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi | 4 ++--
>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi b/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi
>>> index 868454ae6bde..f72c5a03d04c 100644
>>> --- a/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi
>>> +++ b/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi
>>> @@ -93,8 +93,8 @@ gcr: gcr@...000 {
>>>                       reg = <0x800000 0x1000>;
>>>               };
>>>
>>> -             rst: rst@...000 {
>>> -                     compatible = "nuvoton,npcm750-rst", "syscon", "simple-mfd";
>>> +             clk_rst: syscon@...000 {
>>> +                     compatible = "nuvoton,npcm750-clk-rst", "syscon", "simple-mfd";
>>
>> NAK. This breakes the users, is not justified, is not explained.
> Sorry, I didn't understand, which user it is breaking? there isn't a
> device tree node that uses the rst node.

Any user of this DTS.

> Should I explain it better in the commit message?

I doubt that you can find proper reason, because "I want different name"
is not valid. It's just compatible, it cannot be changed just because
you add new property.

Best regards,
Krzysztof