linux-kernel - Re: [PATCH 25/42] drivers/scsi/ibmvscsi: Convert snprintf to sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <92007644-72e3-4312-b9e9-e93e5142e090@linux.ibm.com>
Date: Tue, 16 Jan 2024 13:38:46 -0800
From: Tyrel Datwyler <tyreld@...ux.ibm.com>
To: Li Zhijian <lizhijian@...itsu.com>, linux-kernel@...r.kernel.org
Cc: Michael Ellerman <mpe@...erman.id.au>,
        Nicholas Piggin
 <npiggin@...il.com>,
        Christophe Leroy <christophe.leroy@...roup.eu>,
        "Aneesh Kumar K.V" <aneesh.kumar@...nel.org>,
        "Naveen N. Rao" <naveen.n.rao@...ux.ibm.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH 25/42] drivers/scsi/ibmvscsi: Convert snprintf to
 sysfs_emit

On 1/15/24 20:51, Li Zhijian wrote:
> Per filesystems/sysfs.rst, show() should only use sysfs_emit()
> or sysfs_emit_at() when formatting the value to be returned to user space.
> 
> coccinelle complains that there are still a couple of functions that use
> snprintf(). Convert them to sysfs_emit().
> 
>> ./drivers/scsi/ibmvscsi/ibmvfc.c:3483:8-16: WARNING: please use sysfs_emit
>> ./drivers/scsi/ibmvscsi/ibmvfc.c:3493:8-16: WARNING: please use sysfs_emit
>> ./drivers/scsi/ibmvscsi/ibmvfc.c:3503:8-16: WARNING: please use sysfs_emit
>> ./drivers/scsi/ibmvscsi/ibmvfc.c:3513:8-16: WARNING: please use sysfs_emit
>> ./drivers/scsi/ibmvscsi/ibmvfc.c:3522:8-16: WARNING: please use sysfs_emit
>> ./drivers/scsi/ibmvscsi/ibmvfc.c:3530:8-16: WARNING: please use sysfs_emit
> 
> No functional change intended
> 
> CC: Tyrel Datwyler <tyreld@...ux.ibm.com>
> CC: Michael Ellerman <mpe@...erman.id.au>
> CC: Nicholas Piggin <npiggin@...il.com>
> CC: Christophe Leroy <christophe.leroy@...roup.eu>
> CC: "Aneesh Kumar K.V" <aneesh.kumar@...nel.org>
> CC: "Naveen N. Rao" <naveen.n.rao@...ux.ibm.com>
> CC: "James E.J. Bottomley" <jejb@...ux.ibm.com>
> CC: "Martin K. Petersen" <martin.petersen@...cle.com>
> CC: linux-scsi@...r.kernel.org
> CC: linuxppc-dev@...ts.ozlabs.org
> Signed-off-by: Li Zhijian <lizhijian@...itsu.com>
> ---

Acked-by: Tyrel Datwyler <tyreld@...ux.ibm.com>