linux-kernel - Re: [PATCH v2 2/2] eventfs: Create list of files and directories at dir open

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20240116170154.5bf0a250@gandalf.local.home>
Date: Tue, 16 Jan 2024 17:01:54 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Linux Trace
 Kernel <linux-trace-kernel@...r.kernel.org>, Masami Hiramatsu
 <mhiramat@...nel.org>, Mark Rutland <mark.rutland@....com>, Mathieu
 Desnoyers <mathieu.desnoyers@...icios.com>, Christian Brauner
 <brauner@...nel.org>, Al Viro <viro@...iv.linux.org.uk>, Ajay Kaher
 <ajay.kaher@...adcom.com>, linux-fsdevel <linux-fsdevel@...r.kernel.org>,
 kernel test robot <oliver.sang@...el.com>
Subject: Re: [PATCH v2 2/2] eventfs: Create list of files and directories at
 dir open

On Tue, 16 Jan 2024 13:39:38 -0800
Linus Torvalds <torvalds@...ux-foundation.org> wrote:

> I don't understand why your still insist on this pointless open wrapper.

I just liked the consistency of it.

> 
> Just do this all at iterate time. No open wrappers. No nothing. Just
> iterate over the days structures your have.
> 
> IOW, instead of iterating in open to create the array, just iterate in -
> look, it's in the *name* for chrissake - iterate_shared.
> 
> No array. No random allocation for said array.
> 
> If you can iterate at open time, you can iterate at iterate_shared time.
> Stop creating a list that your already have.
> 
> And nobody cares if you do a readdir at the same time as modifying the
> directory. This isn't a real filesystem with strict POSIX semantics.

OK, I can do that.

-- Steve