linux-kernel - Re: [PATCH 1/3] usb: gadget: function: 9pfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 16 Jan 2024 13:04:08 +0900
From: Dominique Martinet <asmadeus@...ewreck.org>
To: Alan Stern <stern@...land.harvard.edu>
Cc: Michael Grzeschik <m.grzeschik@...gutronix.de>,
	Eric Van Hensbergen <ericvh@...nel.org>,
	Latchesar Ionkov <lucho@...kov.net>,
	Christian Schoenebeck <linux_oss@...debyte.com>,
	Jonathan Corbet <corbet@....net>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	v9fs@...ts.linux.dev, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
	kernel@...gutronix.de
Subject: Re: [PATCH 1/3] usb: gadget: function: 9pfs

Alan Stern wrote on Mon, Jan 15, 2024 at 10:17:34PM -0500:
> > diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> > index b3592bcb0f966..72cdecaef6aa9 100644
> > --- a/drivers/usb/gadget/Kconfig
> > +++ b/drivers/usb/gadget/Kconfig
> > @@ -153,6 +153,10 @@ config USB_F_ACM
> >  config USB_F_SS_LB
> >  	tristate
> >  
> > +config USB_F_9PFS
> > +	tristate
> > +	select NET_9P
> > +
> >  config USB_U_SERIAL
> >  	tristate
> >  
> > @@ -363,6 +367,13 @@ config USB_CONFIGFS_F_LB_SS
> >  	  test software, like the "usbtest" driver, to put your hardware
> >  	  and its driver through a basic set of functional tests.
> >  
> > +config USB_CONFIGFS_F_9PFS
> > +	bool "9pfs over usb gadget"
> > +	depends on USB_CONFIGFS
> > +	select USB_F_9PFS
> > +	help
> > +	  9pfs support for usb gadget
> 
> This may be a dumb question, but what is the purpose of this CONFIG
> symbol?  It doesn't get used by any of the patches in this series, as
> far as I can see.

USB_F_9PFS cannot be selected directly in menuconfig so this allows
configuring the build option -- that appears to be how the other usb
gadgets are configured so I assume it's done that way for consistency
more than out of necessity (I don't see a problem in making the build
system use USB_CONFIGFS_F_9PFS directly, it'd just be different from the
rest)

-- 
Dominique Martinet | Asmadeus