linux-kernel - Re: [PATCH v3 2/5] gpu: host1x: Add Tegra SE to SID table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <84be2248-9789-4b32-8f89-296c0f195835@kapsi.fi>
Date: Tue, 16 Jan 2024 15:36:38 +0900
From: Mikko Perttunen <cyndis@...si.fi>
To: Akhil R <akhilrajeev@...dia.com>, herbert@...dor.apana.org.au,
 davem@...emloft.net, robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
 conor+dt@...nel.org, thierry.reding@...il.com, jonathanh@...dia.com,
 catalin.marinas@....com, will@...nel.org, mperttunen@...dia.com,
 linux-crypto@...r.kernel.org, devicetree@...r.kernel.org,
 linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org, krzk@...nel.org
Subject: Re: [PATCH v3 2/5] gpu: host1x: Add Tegra SE to SID table

On 1/9/24 18:17, Akhil R wrote:
> Add Tegra Security Engine details to the SID table in host1x driver.
> These will be referred when registering the SE as host1x device.

Technically, these entries are required to be in place any time we want 
to configure SE's stream ID. Register writes to stream ID registers fail 
otherwise.

> 
> Signed-off-by: Akhil R <akhilrajeev@...dia.com>
> ---
>   drivers/gpu/host1x/dev.c | 24 ++++++++++++++++++++++++
>   1 file changed, 24 insertions(+)
> 
> diff --git a/drivers/gpu/host1x/dev.c b/drivers/gpu/host1x/dev.c
> index 42fd504abbcd..b564c7042235 100644
> --- a/drivers/gpu/host1x/dev.c
> +++ b/drivers/gpu/host1x/dev.c
> @@ -214,6 +214,30 @@ static const struct host1x_info host1x07_info = {
>    * and firmware stream ID in the MMIO path table.
>    */
>   static const struct host1x_sid_entry tegra234_sid_table[] = {
> +	{
> +		/* SE2 MMIO */
> +		.base = 0x1658,
> +		.offset = 0x90,
> +		.limit = 0x90
> +	},
> +	{
> +		/* SE4 MMIO */
> +		.base = 0x1660,
> +		.offset = 0x90,
> +		.limit = 0x90
> +	},
> +	{
> +		/* SE2 channel */
> +		.base = 0x1738,
> +		.offset = 0x90,
> +		.limit = 0x90
> +	},
> +	{
> +		/* SE4 channel */
> +		.base = 0x1740,
> +		.offset = 0x90,
> +		.limit = 0x90
> +	},
>   	{
>   		/* VIC channel */
>   		.base = 0x17b8,

With the commit message slightly adjusted,

Acked-by: Mikko Perttunen <mperttunen@...dia.com>