linux-kernel - Re: [PATCH v2] irqchip/loongson-eiointc: Refine irq affinity setting during resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <58b05897-8d06-52fa-8cde-ca7caa591200@omp.ru>
Date: Tue, 16 Jan 2024 11:17:24 +0300
From: Sergey Shtylyov <s.shtylyov@....ru>
To: Bibo Mao <maobibo@...ngson.cn>, Huacai Chen <chenhuacai@...nel.org>,
	Jiaxun Yang <jiaxun.yang@...goat.com>, Thomas Gleixner <tglx@...utronix.de>
CC: <linux-mips@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<lvjianmin@...ngson.cn>
Subject: Re: [PATCH v2] irqchip/loongson-eiointc: Refine irq affinity setting
 during resume

On 1/16/24 11:05 AM, Bibo Mao wrote:

> During suspend and resume, other CPUs are hot-unpluged and IRQs are
> migrated to CPU0. So it is not necessary to restore irq affinity for
> eiointc irq controller.
> 
> Also there is some optimization for the interrupt dispatch function
> eiointc_irq_dispatch. There are 256 IRQs supported for eiointc, eiointc
> irq handler reads the bitmap and find pending irqs when irq happens.
> So there are four times of consecutive iocsr_read64 operations for the
> total 256 bits to find all pending irqs. If the pending bitmap is zero,
> it means that there is no pending irq for the this irq bitmap range,
> we can skip handling to avoid some useless operations sush as clearing

    s/sush/such/?

> hw ISR.

   This sounds like you need 2 patches to deal with 2 separate issues...

> Signed-off-by: Bibo Mao <maobibo@...ngson.cn>
[...]

MBR, Sergey