lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 16 Jan 2024 09:31:35 +0100
From: Heiko Stübner <heiko@...ech.de>
To: Tim Lunn <tim@...thertop.org>, KyuHyuk Lee <lee@...hyuk.kr>,
 Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, Chris Morgan <macromorgan@...mail.com>,
 Tianling Shen <cnsztl@...il.com>, Jagan Teki <jagan@...eble.ai>,
 Ondrej Jirman <megi@....cz>, Andy Yan <andyshrk@....com>,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject:
 Re: [PATCH] dt-bindings: rockchip: Fix Hardkernel ODROID-M1 board bindings

Am Dienstag, 16. Januar 2024, 08:24:44 CET schrieb Krzysztof Kozlowski:
> On 16/01/2024 03:00, Tim Lunn wrote:
> > 
> > On 1/16/24 01:58, Krzysztof Kozlowski wrote:
> >> On 15/01/2024 15:51, KyuHyuk Lee wrote:
> >>> The vendor in ODROID-M1 is hardkernel, but it was incorrectly written
> >>> as rockchip. Fixed the vendor prefix correctly.
> >>>
> >>> Signed-off-by: KyuHyuk Lee <lee@...hyuk.kr>
> >>> ---
> >>>   Documentation/devicetree/bindings/arm/rockchip.yaml | 2 +-
> >>>   1 file changed, 1 insertion(+), 1 deletion(-)
> >> You need to start testing your patches. Your last M1 fails as well in
> >> multiple places.
> >>
> >> It does not look like you tested the DTS against bindings. Please run
> >> `make dtbs_check W=1` (see
> >> Documentation/devicetree/bindings/writing-schema.rst or
> >> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
> >> for instructions).
> >>
> >> The DTS change will break the users, so would be nice to mention this in
> >> its commit msg.
> > 
> > I notice there are a couple of other boards that incorrectly use 
> > rockchip as the vendor also:
> > 
> >            - const: rockchip,rk3399-orangepi
> >            - const: rockchip,rk3568-bpi-r2pro
> > 
> > Perhaps these should also be fixed at the same time?
> 
> What is happening with rockchip boards?

Copy-paste stuff ... boards using rockchip,boardname instead of
vendor,boardname for their compatible.

I do remember us noticing this a number of times on some boards
and requesting fixes, but looks like some slipped through.

So I guess Tim is suggesting changing the compatible, but with boards
being merged a while ago, this would break backwards compatibility.
So I guess both the Orange and Banana Pies will need to live with that.



Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ