linux-kernel - Re: [PATCH v8 1/5] dt-bindings: clock: sophgo: add sysclk for SG2042

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6badfa7b-543f-4aa0-87db-bac27c2d1f46@linaro.org>
Date: Tue, 16 Jan 2024 11:09:00 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Chen Wang <unicornxw@...il.com>, aou@...s.berkeley.edu,
 chao.wei@...hgo.com, conor@...nel.org, krzysztof.kozlowski+dt@...aro.org,
 mturquette@...libre.com, palmer@...belt.com, paul.walmsley@...ive.com,
 richardcochran@...il.com, robh+dt@...nel.org, sboyd@...nel.org,
 devicetree@...r.kernel.org, linux-clk@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org,
 haijiao.liu@...hgo.com, xiaoguang.xing@...hgo.com, guoren@...nel.org,
 jszhang@...nel.org, inochiama@...look.com, samuel.holland@...ive.com
Cc: Chen Wang <unicorn_wang@...look.com>
Subject: Re: [PATCH v8 1/5] dt-bindings: clock: sophgo: add sysclk for SG2042

On 16/01/2024 08:20, Chen Wang wrote:
> From: Chen Wang <unicorn_wang@...look.com>
> 
> Add bindings for the clocks of which configuration registers are in the
> range of SYS_CTRL in the memory-map.

This means it is not a separate device and should be just merged with
parent node. Otherwise please give us some arguments why this should be
a separate device node.


> 
> Signed-off-by: Chen Wang <unicorn_wang@...look.com>
> 
> .

Some stray characters above ^^^. Clean your commit msg. Also, I have
doubts it passes checkpatch.


Best regards,
Krzysztof