linux-kernel - End of 4.14 autosel? Re: [PATCH AUTOSEL 4.14 3/6] drm/crtc: Fix uninit-value bug in drm_mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZaZelbUWUsmYxLPB@duo.ucw.cz>
Date: Tue, 16 Jan 2024 11:46:45 +0100
From: Pavel Machek <pavel@....cz>
To: Sasha Levin <sashal@...nel.org>
Cc: Jani Nikula <jani.nikula@...ux.intel.com>, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org, tzimmermann@...e.de,
	Ziqi Zhao <astrajoan@...oo.com>, Maxime Ripard <mripard@...nel.org>,
	dri-devel@...ts.freedesktop.org,
	Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>,
	syzbot+4fad2e57beb6397ab2fc@...kaller.appspotmail.com
Subject: End of 4.14 autosel? Re: [PATCH AUTOSEL 4.14 3/6] drm/crtc: Fix
 uninit-value bug in drm_mode_setcrtc

Hi!

> > > From: Ziqi Zhao <astrajoan@...oo.com>
> > > 
> > > [ Upstream commit 3823119b9c2b5f9e9b760336f75bc989b805cde6 ]
> > > 
> > > The connector_set contains uninitialized values when allocated with
> > > kmalloc_array. However, in the "out" branch, the logic assumes that any
> > > element in connector_set would be equal to NULL if failed to
> > > initialize, which causes the bug reported by Syzbot. The fix is to use
> > > an extra variable to keep track of how many connectors are initialized
> > > indeed, and use that variable to decrease any refcounts in the "out"
> > > branch.
> > > 
> > > Reported-by: syzbot+4fad2e57beb6397ab2fc@...kaller.appspotmail.com
> > > Signed-off-by: Ziqi Zhao <astrajoan@...oo.com>
> > > Reported-and-tested-by: syzbot+4fad2e57beb6397ab2fc@...kaller.appspotmail.com
> > > Tested-by: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
> > > Link: https://lore.kernel.org/r/20230721161446.8602-1-astrajoan@yahoo.com
> > > Signed-off-by: Maxime Ripard <mripard@...nel.org>
> > > Signed-off-by: Sasha Levin <sashal@...nel.org>
> > 
> > This commit fixes an uninitialized value, but introduces a new
> > one. Please backport 6e455f5dcdd1 ("drm/crtc: fix uninitialized variable
> > use") from v6.7-rc6 to go with it.
> 
> I'll take 6e455f5dcdd1 too, thanks!

So, what is the status of 4.14-stable? Last one was
marked. .. well. .. as last one, so perhaps AUTOSEL should start
ignoring it, too?

Best regards,
								Pavel
-- 
People of Russia, stop Putin before his war on Ukraine escalates.

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)