linux-kernel - Re: vfio/platform: Use common error handling code in vfio_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ab6bcd8b-f53c-47d1-8c55-c374a36d6ee4@web.de>
Date: Tue, 16 Jan 2024 12:32:23 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Alex Williamson <alex.williamson@...hat.com>,
 Eric Auger <eric.auger@...hat.com>, kvm@...r.kernel.org,
 kernel-janitors@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: vfio/platform: Use common error handling code in
 vfio_set_trigger()

> TBH, this doesn't seem like a worthwhile exit point consolidation.  A
> change like this might be justified if there were some common unlock
> code that could be shared, but for a simple free and return errno by
> jumping to a different exception block, rather than even a common exit
> block, I don't see the value.

Can it be helpful to store the shown kfree() call only once
in this function implementation?

Regards,
Markus