linux-kernel - Re: [PATCH v3] drm/ci: add tests on vkms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 16 Jan 2024 17:13:07 +0530
From: Vignesh Raman <vignesh.raman@...labora.com>
To: Helen Koike <helen.koike@...labora.com>, dri-devel@...ts.freedesktop.org
Cc: hamohammed.sa@...il.com, daniels@...labora.com,
 rodrigosiqueiramelo@...il.com, mairacanal@...eup.net,
 guilherme.gallo@...labora.com, sergi.blanch.torne@...labora.com,
 linux-kernel@...r.kernel.org, melissa.srw@...il.com,
 david.heidelberg@...labora.com, airlied@...il.com
Subject: Re: [PATCH v3] drm/ci: add tests on vkms

Hi Helen,

On 15/01/24 20:54, Helen Koike wrote:
>> diff --git a/drivers/gpu/drm/ci/gitlab-ci.yml 
>> b/drivers/gpu/drm/ci/gitlab-ci.yml
>> index 084e3ff8e3f4..4b636d39734c 100644
>> --- a/drivers/gpu/drm/ci/gitlab-ci.yml
>> +++ b/drivers/gpu/drm/ci/gitlab-ci.yml
>> @@ -108,6 +108,7 @@ stages:
>>     - rockchip
>>     - virtio-gpu
>>     - lint
>> +  - software-driver
> 
> I had created this new stage with the intention to also move virtio-gpu 
> to it, so we can patch all "non-real" hardware, what do you think?

Yes we can move virtio-gpu job also to software-driver stage.

>> diff --git a/drivers/gpu/drm/ci/x86_64.config 
>> b/drivers/gpu/drm/ci/x86_64.config
>> index 1cbd49a5b23a..ab4dcca749cc 100644
>> --- a/drivers/gpu/drm/ci/x86_64.config
>> +++ b/drivers/gpu/drm/ci/x86_64.config
>> @@ -24,6 +24,7 @@ CONFIG_DRM=y
>>   CONFIG_DRM_PANEL_SIMPLE=y
>>   CONFIG_PWM_CROS_EC=y
>>   CONFIG_BACKLIGHT_PWM=y
>> +CONFIG_DRM_VKMS=y
> 
> I was wondering if this wouldn't get in the way of other tests, but I 
> guess IGT_FORCE_DRIVER can handle, we just need to make sure it is set 
> and we are testing the correct one.

Yes, we need to skip the vkms tests for other drivers. I think we can go 
with your modprobe approach. We need kmod in debian/x86_64_test-gl 
container to get it working. I have created a MR in mesa for this.

https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27088

Once this is merged, will uprev mesa in drm-ci and send updated vkms patch.

Thanks.

Regards,
Vignesh