linux-kernel - RE: [PATCH] selftests/mm: switch to bash from sh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 16 Jan 2024 16:52:25 +0000
From: David Laight <David.Laight@...LAB.COM>
To: 'Muhammad Usama Anjum' <usama.anjum@...labora.com>, Andrew Morton
	<akpm@...ux-foundation.org>, Shuah Khan <shuah@...nel.org>
CC: "kernel@...labora.com" <kernel@...labora.com>, "linux-mm@...ck.org"
	<linux-mm@...ck.org>, "linux-kselftest@...r.kernel.org"
	<linux-kselftest@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] selftests/mm: switch to bash from sh

From: Muhammad Usama Anjum
> Sent: 16 January 2024 09:05
> 
> Running charge_reserved_hugetlb.sh generates errors if sh is set to
> dash:
> 
> /charge_reserved_hugetlb.sh: 9: [[: not found
> /charge_reserved_hugetlb.sh: 19: [[: not found
> /charge_reserved_hugetlb.sh: 27: [[: not found
> /charge_reserved_hugetlb.sh: 37: [[: not found
> /charge_reserved_hugetlb.sh: 45: Syntax error: "(" unexpected
> 
> Switch to using /bin/bash instead of /bin/sh. Make the switch for
> write_hugetlb_memory.sh as well which is called from
> charge_reserved_hugetlb.sh.

Why not just fix the script?
Looks like most of the [[ ... ]] could be [ ... ]
although some might need to be [ -n "$cgroup2" ].
The delete the 'function' keyword another bash-ism.

It's not as though you are trying to run on a system
when /bin/sh is a traditional (aka non-posix) bourne shell.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)