linux-kernel - Re: [PATCH] scsi: fcoe: Fix unsigned comparison with zero in store_ctlr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <170552035090.3348001.8757972022614438996.b4-ty@oracle.com>
Date: Wed, 17 Jan 2024 15:10:06 -0500
From: "Martin K. Petersen" <martin.petersen@...cle.com>
To: Hannes Reinecke <hare@...e.de>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        Justin Stitt <justinstitt@...gle.com>,
        Kees Cook <keescook@...omium.org>, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
Cc: "Martin K . Petersen" <martin.petersen@...cle.com>,
        dan.carpenter@...aro.org, kernel-janitors@...r.kernel.org,
        error27@...il.com
Subject: Re: [PATCH] scsi: fcoe: Fix unsigned comparison with zero in store_ctlr_mode()

On Tue, 02 Jan 2024 00:52:45 -0800, Harshit Mogalapalli wrote:

> ctlr->mode is of unsigned type, it is never less than zero.
> 
> Fix this by using an extra varibale called 'res', to store return value
> from sysfs_match_string() and assign that to ctlr->mode on the success
> path.
> 
> 
> [...]

Applied to 6.8/scsi-queue, thanks!

[1/1] scsi: fcoe: Fix unsigned comparison with zero in store_ctlr_mode()
      https://git.kernel.org/mkp/scsi/c/567a1e852e87

-- 
Martin K. Petersen	Oracle Linux Engineering