linux-kernel - Re: [PATCH v3 1/3] gpio: vf610: add support to DT 'ngpios' property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 17 Jan 2024 22:51:59 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Hector Palacios <hector.palacios@...i.com>
Cc: linus.walleij@...aro.org, brgl@...ev.pl, robh+dt@...nel.org, 
	krzysztof.kozlowski+dt@...aro.org, andy@...nel.org, conor+dt@...nel.org, 
	shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de, 
	festevam@...il.com, linux-imx@....com, stefan@...er.ch, 
	linux-gpio@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/3] gpio: vf610: add support to DT 'ngpios' property

On Wed, Jan 17, 2024 at 10:35 AM Hector Palacios
<hector.palacios@...i.com> wrote:
>
> Some SoCs, such as i.MX93, don't have all 32 pins available
> per port. Allow optional generic 'ngpios' property to be
> specified from the device tree and default to
> VF610_GPIO_PER_PORT (32) if the property does not exist.

..

> +       ret = device_property_read_u32(dev, "ngpios", &ngpios);
> +       if (ret || ngpios > VF610_GPIO_PER_PORT)
> +               gc->ngpio = VF610_GPIO_PER_PORT;
> +       else
> +               gc->ngpio = (u16)ngpios;

This property is being read by the GPIOLIB core. Why do you need to repeat this?

-- 
With Best Regards,
Andy Shevchenko