linux-kernel - Re: [RFC PATCH 4/4] kernel/workqueue: Let rescuers follow unbound wq cpumask changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJhGHyBuf02mh=ezoua33UNu5QTpwP=qf-WP_C2qVyx_HEtMDg@mail.gmail.com>
Date: Wed, 17 Jan 2024 11:56:44 +0800
From: Lai Jiangshan <jiangshanlai@...il.com>
To: Juri Lelli <juri.lelli@...hat.com>
Cc: Tejun Heo <tj@...nel.org>, Aaron Tomlin <atomlin@...mlin.com>, 
	Valentin Schneider <vschneid@...hat.com>, Waiman Long <longman@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 4/4] kernel/workqueue: Let rescuers follow unbound wq
 cpumask changes

Hello, Juri

On Wed, Jan 17, 2024 at 12:20 AM Juri Lelli <juri.lelli@...hat.com> wrote:

> +       /* rescuer needs to respect wq cpumask changes */
> +       if (ctx->wq->rescuer) {
> +               set_cpus_allowed_ptr(ctx->wq->rescuer->task, ctx->attrs->cpumask);
> +               wake_up_process(ctx->wq->rescuer->task);
> +       }
> +

What's the reason to wake up the rescuer?

I support this patch except for the wakeup:
Reviewed-by: Lai Jiangshan <jiangshanlai@...il.com>

Thanks

Lai