linux-kernel - Re: [PATCH 2/2] arm64: dts: rockchip: rock-pi-e: fix location of snps properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGb2v67KfNR_U_Qz85aqY1D0DKE9mo-X_L8MGvT7cdcZGUHVUg@mail.gmail.com>
Date: Wed, 17 Jan 2024 12:38:39 +0800
From: Chen-Yu Tsai <wens@...e.org>
To: Trevor Woerner <twoerner@...il.com>
Cc: linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>, 
	Heiko Stuebner <heiko@...ech.de>, devicetree@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: rock-pi-e: fix location of snps properties

On Wed, Jan 17, 2024 at 4:41 AM Trevor Woerner <twoerner@...il.com> wrote:
>
> A number of snps (Synopsys) properties are not in their correct location.

Nope. If you read the snps,dwmac.yaml binding file, you'll see that these
properties have been deprecated. They are properties pertaining to the PHY
and should be described under the PHY node. Support for reset GPIOs on PHY
devices in phylib has been there since v4.16. The snps prefixed properties
were deprecated in v5.3.

ChenYu

> Fixes: b918e81f2145 ("arm64: dts: rockchip: rk3328: Add Radxa ROCK Pi E")
> Signed-off-by: Trevor Woerner <twoerner@...il.com>
> ---
>  arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts b/arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts
> index 096cfa19036e..0739b8fec86e 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts
> @@ -150,8 +150,11 @@ &gmac2io {
>         phy-mode = "rgmii";
>         phy-supply = <&vcc_io>;
>         pinctrl-names = "default";
> -       pinctrl-0 = <&rgmiim1_pins>;
> +       pinctrl-0 = <&rgmiim1_pins>, <&eth_phy_reset_pin>;
>         snps,aal;
> +       snps,reset-gpio = <&gpio1 RK_PC2 GPIO_ACTIVE_LOW>;
> +       snps,reset-active-low;
> +       snps,reset-delays-us = <0 10000 50000>;
>         snps,rxpbl = <0x4>;
>         snps,txpbl = <0x4>;
>         tx_delay = <0x26>;
> @@ -165,13 +168,10 @@ mdio {
>
>                 rtl8211: ethernet-phy@1 {
>                         reg = <1>;
> -                       pinctrl-0 = <&eth_phy_int_pin>, <&eth_phy_reset_pin>;
> +                       pinctrl-0 = <&eth_phy_int_pin>;
>                         pinctrl-names = "default";
>                         interrupt-parent = <&gpio1>;
>                         interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
> -                       reset-assert-us = <10000>;
> -                       reset-deassert-us = <50000>;
> -                       reset-gpios = <&gpio1 RK_PC2 GPIO_ACTIVE_LOW>;
>                 };
>         };
>  };
> --
> 2.43.0.76.g1a87c842ece3
>