linux-kernel - Re: [PATCH 1/1] mm: vmalloc: Mark vmap_init_free_space() with _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 17 Jan 2024 11:38:28 +0530
From: Anshuman Khandual <anshuman.khandual@....com>
To: "Uladzislau Rezki (Sony)" <urezki@...il.com>, linux-mm@...ck.org,
 Andrew Morton <akpm@...ux-foundation.org>
Cc: LKML <linux-kernel@...r.kernel.org>, Baoquan He <bhe@...hat.com>,
 Lorenzo Stoakes <lstoakes@...il.com>, Christoph Hellwig <hch@...radead.org>,
 Matthew Wilcox <willy@...radead.org>,
 "Liam R . Howlett" <Liam.Howlett@...cle.com>,
 Dave Chinner <david@...morbit.com>,
 Oleksiy Avramchenko <oleksiy.avramchenko@...y.com>,
 kernel test robot <lkp@...el.com>
Subject: Re: [PATCH 1/1] mm: vmalloc: Mark vmap_init_free_space() with __init
 tag

On 1/11/24 18:56, Uladzislau Rezki (Sony) wrote:
> The vmap_init_free_space() function is called only once
> therefore tag it with __init. Apart of that it access the
> "vmlist" variable that is located in ".init.data" section.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202401112056.I41bELL4-lkp@intel.com/
> Fixes: 86817057732 ("mm: vmalloc: remove global vmap_area_root rb-tree")
> Signed-off-by: Uladzislau Rezki (Sony) <urezki@...il.com>
> ---
>  mm/vmalloc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index 43a6608e1397..257981e37936 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -4834,7 +4834,7 @@ module_init(proc_vmalloc_init);
>  
>  #endif
>  
> -static void vmap_init_free_space(void)
> +static void __init vmap_init_free_space(void)
>  {
>  	unsigned long vmap_start = 1;
>  	const unsigned long vmap_end = ULONG_MAX;

LGTM

Reviewed-by: Anshuman Khandual <anshuman.khandual@....com>