linux-kernel - [PATCH] printk: nbcon: check uart port is nbcon or not in nbcon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240117065226.4166127-1-junxiao.chang@intel.com>
Date: Wed, 17 Jan 2024 14:52:26 +0800
From: Junxiao Chang <junxiao.chang@...el.com>
To: bigeasy@...utronix.de,
	tglx@...utronix.de,
	rostedt@...dmis.org,
	linux-kernel@...r.kernel.org
Cc: john.ogness@...utronix.de,
	hao3.li@...el.com,
	lili.li@...el.com,
	jianfeng.gao@...el.com,
	linux-rt-users@...r.kernel.org
Subject: [PATCH] printk: nbcon: check uart port is nbcon or not in nbcon_release

Different uart ports might have same console pointer, not all of
uart ports are nbcon. When uart port is shutdown, only release
nbcon if it is nbcon. There is same nbcon checking in API
nbcon_acquire.

Fixes: 6424f396c49e ("printk: nbcon: Implement processing in port->lock wrapper")
Signed-off-by: Junxiao Chang <junxiao.chang@...el.com>
---
 kernel/printk/nbcon.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/kernel/printk/nbcon.c b/kernel/printk/nbcon.c
index 1b1b585b1675b..e53b8bebbb57e 100644
--- a/kernel/printk/nbcon.c
+++ b/kernel/printk/nbcon.c
@@ -1623,6 +1623,9 @@ void nbcon_release(struct uart_port *up)
 		.prio		= NBCON_PRIO_NORMAL,
 	};
 
+	if (!uart_is_nbcon(up))
+		return;
+
 	if (!con->locked_port)
 		return;
 
-- 
2.34.1