[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a98f1927-53fe-420c-86d0-e91eeab0e9ab@linaro.org>
Date: Wed, 17 Jan 2024 08:43:01 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Tim Lunn <tim@...thertop.org>, linux-rockchip@...ts.infradead.org,
devicetree@...r.kernel.org
Cc: linux-arm-kernel@...ts.infradead.org, Chris Zhong <zyw@...k-chips.com>,
Conor Dooley <conor+dt@...nel.org>, Heiko Stuebner <heiko@...ech.de>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Lee Jones <lee@...nel.org>, Rob Herring <robh+dt@...nel.org>,
Zhang Qing <zhangqing@...k-chips.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: rockchip: Document rk809 support for
rk817 audio codec
On 16/01/2024 14:21, Tim Lunn wrote:
> Rockchip RK809 shares the same audio codec as the rk817 mfd, it is also
> using the same rk817_codec driver. However it is missing from the
> bindings.
>
> Update dt-binding documentation for rk809 to include the audio codec
> properties. This fixes the following warning from dtb check:
>
> pmic@20: '#sound-dai-cells', 'assigned-clock-parents', 'assigned-clocks',
> 'clock-names', 'clocks', 'codec' do not match any of the regexes:
> 'pinctrl-[0-9]+'
>
> Signed-off-by: Tim Lunn <tim@...thertop.org>
> ---
>
> (no changes since v1)
>
> .../bindings/mfd/rockchip,rk809.yaml | 30 ++++++++++++++++++-
> 1 file changed, 29 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml b/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml
> index 839c0521f1e5..bac2e751e2f2 100644
> --- a/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml
> +++ b/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml
> @@ -12,7 +12,7 @@ maintainers:
>
> description: |
> Rockchip RK809 series PMIC. This device consists of an i2c controlled MFD
> - that includes regulators, an RTC, and power button.
> + that includes regulators, an RTC, a power button, and an audio codec.
>
> properties:
> compatible:
> @@ -93,6 +93,34 @@ properties:
> unevaluatedProperties: false
> unevaluatedProperties: false
>
> + clocks:
> + description:
> + The input clock for the audio codec.
Nothing improved here. Implement the feedback.
Don't send the patchsets more than once per day, so reviewers can
actually review it.
Best regards,
Krzysztof
Powered by blists - more mailing lists