linux-kernel - Re: [PATCH] ARM: dts: tps65217: add power regulator & backlight drivers support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b30ed845-5900-470d-aa73-f47332b539ba@linaro.org>
Date: Wed, 17 Jan 2024 09:01:41 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Xulin Sun <xulin.sun@...driver.com>, robh+dt@...nel.org,
 krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: tps65217: add power regulator & backlight
 drivers support

On 17/01/2024 08:56, Xulin Sun wrote:
> On 1/17/24 15:24, Krzysztof Kozlowski wrote:
>> On 17/01/2024 05:33, Xulin Sun wrote:
>>> Support TPS65217 voltage regulator driver and TPS65217 Backlight driver.
>>> And enable them by default. This will avoid below booting failed
>>> information:
>>> tps65217-pmic: Failed to locate of_node [id: -1]
>>> tps65217-bl: Failed to locate of_node [id: -1]
>>>
>>> Signed-off-by: Xulin Sun <xulin.sun@...driver.com>
>>> ---
>>>   arch/arm/boot/dts/tps65217.dtsi | 10 ++++++++++
>>>   1 file changed, 10 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/tps65217.dtsi b/arch/arm/boot/dts/tps65217.dtsi
>>> index 0d463de5650f..f412e7476660 100644
>>> --- a/arch/arm/boot/dts/tps65217.dtsi
>>> +++ b/arch/arm/boot/dts/tps65217.dtsi
>>> @@ -13,6 +13,16 @@ &tps {
>>>   	interrupt-controller;
>>>   	#interrupt-cells = <1>;
>>>   
>>> +	pmic {
>>> +		compatible = "ti,tps65217-pmic";
>>> +		status = "okay";
>> Why do you need status here?
> 
> 
> It corresponds to the drvier: drivers/regulator/tps65217-regulator.c, 
> and regulator is one of the main function of TPS65217.

status does not correspond to the driver.

> 
> I think it should be enabled by default, so set status to "okay" here.

It is the default. Is it disabled anywhere?

Best regards,
Krzysztof