linux-kernel - RE: [PATCH] printk: nbcon: check uart port is nbcon or not in nbcon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 17 Jan 2024 08:45:03 +0000
From: "Chang, Junxiao" <junxiao.chang@...el.com>
To: John Ogness <john.ogness@...utronix.de>, "bigeasy@...utronix.de"
	<bigeasy@...utronix.de>, "tglx@...utronix.de" <tglx@...utronix.de>,
	"rostedt@...dmis.org" <rostedt@...dmis.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
CC: "Li, Hao3" <hao3.li@...el.com>, "Li, Lili" <lili.li@...el.com>, "Gao,
 Jianfeng" <jianfeng.gao@...el.com>, "linux-rt-users@...r.kernel.org"
	<linux-rt-users@...r.kernel.org>
Subject: RE: [PATCH] printk: nbcon: check uart port is nbcon or not in
 nbcon_release

There are several serial ports in one Intel ADL hardware, they are enumerated as ttyS0, ttyS1, ttyS4, and so on. Multiple console options might be appended to kernel command line. For example, "console=ttyS0,115200n8 console=ttyS4,115200n8 console=ttyS5,115200n8".

In this case, several uarts "cons" pointers are same.

During booting up process, login thread "agetty" might shutdown all uart. All uart ports could release nbcon lock even if they are "non nbcon" console However, in "nbcon_acquire" API, if uart is not nbcon, it returns directly didn't lock anything.

This patch fixes a boot hang issue which could be reproduced every time with Intel ADL hardware/v6.6.7-rt18 kernel. BTW, this issue couldn't be reproduced with v6.6.7-rt17 kernel.

Thanks,
Junxiao

-----Original Message-----
From: John Ogness <john.ogness@...utronix.de> 
Sent: Wednesday, January 17, 2024 4:24 PM
To: Chang, Junxiao <junxiao.chang@...el.com>; bigeasy@...utronix.de; tglx@...utronix.de; rostedt@...dmis.org; linux-kernel@...r.kernel.org
Cc: Li, Hao3 <hao3.li@...el.com>; Li, Lili <lili.li@...el.com>; Gao, Jianfeng <jianfeng.gao@...el.com>; linux-rt-users@...r.kernel.org
Subject: Re: [PATCH] printk: nbcon: check uart port is nbcon or not in nbcon_release

On 2024-01-17, Junxiao Chang <junxiao.chang@...el.com> wrote:
> Different uart ports might have same console pointer,

Please explain how this is possible. It would be a major bug.

John