linux-kernel - Re: [PATCH] dt-bindings: serial: stm32: add power-domains property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <76ae9e57-091e-429f-97ed-1a1b4f992d79@linaro.org>
Date: Wed, 17 Jan 2024 10:23:37 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Valentin CARON <valentin.caron@...s.st.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Jiri Slaby <jirislaby@...nel.org>, Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>
Cc: linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 linux-stm32@...md-mailman.stormreply.com,
 linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] dt-bindings: serial: stm32: add power-domains property

On 17/01/2024 10:21, Valentin CARON wrote:
> 
> On 1/15/24 16:05, Krzysztof Kozlowski wrote:
>> On 11/01/2024 12:24, Valentin Caron wrote:
>>> Add "power-domains" property in stm32 serial binding to avoid:
>>>
>>> serial@...10000: Unevaluated properties are not allowed
>>> ('power-domains' were unexpected)
>>>
>> It would be better if you checked whether it can be part of power domain
>> or not. What if the DTS is wrong?
>>
>> Best regards,
>> Krzysztof
>>
> Hi Krzysztof,
> 
> I'm not sure to understand, but if you mean that there is no
> power-domains properties right now in all stm32mp device trees
> and so it does not required to add this stm32 serial bindings:
> 
> Theses will be upstreamed in the future, and because power-domains
> property is optional, I can add it right now in stm32 serial binding
> to anticipate.

No. You used argument: "add because DTS has it" and I want different
argument: "add because it is the right thing to do because foo and bar".
If DTS is wrong, then your commit and this explanation is wrong.

Best regards,
Krzysztof