linux-kernel - Re: [PATCH v11 12/15] media: uapi: Add an entity type for audio resampler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 17 Jan 2024 10:59:08 +0100
From: Hans Verkuil <hverkuil@...all.nl>
To: Shengjiu Wang <shengjiu.wang@....com>, sakari.ailus@....fi,
 tfiga@...omium.org, m.szyprowski@...sung.com, mchehab@...nel.org,
 linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
 shengjiu.wang@...il.com, Xiubo.Lee@...il.com, festevam@...il.com,
 nicoleotsuka@...il.com, lgirdwood@...il.com, broonie@...nel.org,
 perex@...ex.cz, tiwai@...e.com, alsa-devel@...a-project.org,
 linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH v11 12/15] media: uapi: Add an entity type for audio
 resampler

Some small comments:

On 22/11/2023 08:23, Shengjiu Wang wrote:
> Add and document a media entity type for audio resampler.

for -> for an

> It is MEDIA_ENT_F_PROC_AUDIO_RESAMPLER.
> 
> Signed-off-by: Shengjiu Wang <shengjiu.wang@....com>
> ---
>  Documentation/userspace-api/media/mediactl/media-types.rst | 6 ++++++
>  include/uapi/linux/media.h                                 | 1 +
>  2 files changed, 7 insertions(+)
> 
> diff --git a/Documentation/userspace-api/media/mediactl/media-types.rst b/Documentation/userspace-api/media/mediactl/media-types.rst
> index f0880aea41d6..abbe515dad76 100644
> --- a/Documentation/userspace-api/media/mediactl/media-types.rst
> +++ b/Documentation/userspace-api/media/mediactl/media-types.rst
> @@ -40,6 +40,7 @@ Types and flags used to represent the media graph elements
>  .. _MEDIA-ENT-F-PROC-VIDEO-ENCODER:
>  .. _MEDIA-ENT-F-PROC-VIDEO-DECODER:
>  .. _MEDIA-ENT-F-PROC-VIDEO-ISP:
> +.. _MEDIA-ENT-F-PROC-AUDIO-RESAMPLER:
>  .. _MEDIA-ENT-F-VID-MUX:
>  .. _MEDIA-ENT-F-VID-IF-BRIDGE:
>  .. _MEDIA-ENT-F-DV-DECODER:
> @@ -208,6 +209,11 @@ Types and flags used to represent the media graph elements
>  	  combination of custom V4L2 controls and IOCTLs, and parameters
>  	  supplied in a metadata buffer.
>  
> +    *  -  ``MEDIA_ENT_F_PROC_AUDIO_RESAMPLER``
> +       -  An Audio Resampler device. An entity capable of
> +	  resampling a audio stream from one sample rate to another sample

a audio -> an audio

> +	  rate. Must have one sink pad and at least one source pad.
> +
>      *  -  ``MEDIA_ENT_F_VID_MUX``
>         - Video multiplexer. An entity capable of multiplexing must have at
>           least two sink pads and one source pad, and must pass the video
> diff --git a/include/uapi/linux/media.h b/include/uapi/linux/media.h
> index 9ff6dec7393a..a8266eaa8042 100644
> --- a/include/uapi/linux/media.h
> +++ b/include/uapi/linux/media.h
> @@ -125,6 +125,7 @@ struct media_device_info {
>  #define MEDIA_ENT_F_PROC_VIDEO_ENCODER		(MEDIA_ENT_F_BASE + 0x4007)
>  #define MEDIA_ENT_F_PROC_VIDEO_DECODER		(MEDIA_ENT_F_BASE + 0x4008)
>  #define MEDIA_ENT_F_PROC_VIDEO_ISP		(MEDIA_ENT_F_BASE + 0x4009)
> +#define MEDIA_ENT_F_PROC_AUDIO_RESAMPLER	(MEDIA_ENT_F_BASE + 0x400a)
>  
>  /*
>   * Switch and bridge entity functions

Regards,

	Hans