[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e87a86a2-ce5b-07cb-a567-439696fe4775@arm.com>
Date: Wed, 17 Jan 2024 10:12:13 +0000
From: James Clark <james.clark@....com>
To: Ruidong Tian <tianruidong@...ux.alibaba.com>, linux-kernel@...r.kernel.org
Cc: coresight@...ts.linaro.org, suzuki.poulose@....com,
mike.leach@...aro.org, alexander.shishkin@...ux.intel.com,
linux-arm-kernel@...ts.infradead.org, adrian.hunter@...el.com,
linux-perf-users@...r.kernel.org, leo.yan@...aro.org, al.grant@....com,
mathieu.poirier@...aro.org, tor@...com, acme@...hat.com
Subject: Re: [PATCH v3 2/3] perf scripts python: arm-cs-trace-disasm.py: set
start vm addr of exectable file to 0
On 16/01/2024 02:08, Ruidong Tian wrote:
> For exectable ELF file, which e_type is ET_EXEC, dso start address is a
> absolute address other than offset. Just set vm_start to zero when dso
> start is 0x400000, which means it is a exectable file.
>
> Signed-off-by: Ruidong Tian <tianruidong@...ux.alibaba.com>
> ---
> tools/perf/scripts/python/arm-cs-trace-disasm.py | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/scripts/python/arm-cs-trace-disasm.py b/tools/perf/scripts/python/arm-cs-trace-disasm.py
> index 46bf6b02eea1..c9e14af5b58c 100755
> --- a/tools/perf/scripts/python/arm-cs-trace-disasm.py
> +++ b/tools/perf/scripts/python/arm-cs-trace-disasm.py
> @@ -260,8 +260,9 @@ def process_event(param_dict):
>
> if (options.objdump_name != None):
> # It doesn't need to decrease virtual memory offset for disassembly
> - # for kernel dso, so in this case we set vm_start to zero.
> - if (dso == "[kernel.kallsyms]"):
> + # for kernel dso and executable file dso, so in this case we set
> + # vm_start to zero.
> + if (dso == "[kernel.kallsyms]" or dso_start == 0x400000):
> dso_vm_start = 0
> else:
> dso_vm_start = int(dso_start)
Hi Ruidong,
Please pick up my review tag from V1 for this patch if you resend. You
can apply the review tags automatically with the b4 tool.
Thanks
James
Powered by blists - more mailing lists