linux-kernel - Re: [PATCH AUTOSEL 6.7 050/108] net: wangxun: fix changing mac failed when running

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240116173955.57ba27f3@kernel.org>
Date: Tue, 16 Jan 2024 17:39:55 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Sasha Levin <sashal@...nel.org>
Cc: linux-kernel@...r.kernel.org, stable@...r.kernel.org, duanqiangwen
 <duanqiangwen@...-swift.com>, jiawenwu@...stnetic.com,
 mengyuanlou@...-swift.com, davem@...emloft.net, edumazet@...gle.com,
 pabeni@...hat.com, andrew@...n.ch, bhelgaas@...gle.com,
 maciej.fijalkowski@...el.com, horms@...nel.org, netdev@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 6.7 050/108] net: wangxun: fix changing mac
 failed when running

On Tue, 16 Jan 2024 14:39:16 -0500 Sasha Levin wrote:
> in some bonding mode, service need to change mac when
> netif is running. Wangxun netdev add IFF_LIVE_ADDR_CHANGE
> priv_flag to support it.

Not really a fix, more of a feature ennoblement.
Let's drop it, we don't know what it may uncover.

We should probably start complaining when people use 
the word "fix" for non-fixes :(