[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <66a63c5f-d26e-400a-910a-3d4ebb11f286@feathertop.org>
Date: Wed, 17 Jan 2024 22:08:31 +1100
From: Tim Lunn <tim@...thertop.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
Rob Herring <robh@...nel.org>
Cc: linux-rockchip@...ts.infradead.org, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, Chris Zhong <zyw@...k-chips.com>,
Conor Dooley <conor+dt@...nel.org>, Heiko Stuebner <heiko@...ech.de>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Lee Jones <lee@...nel.org>, Zhang Qing <zhangqing@...k-chips.com>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: rockchip: Add rk809 support for rk817
audio codec
On 1/17/24 21:57, Krzysztof Kozlowski wrote:
> On 17/01/2024 11:38, Tim Lunn wrote:
>> On 1/17/24 21:12, Krzysztof Kozlowski wrote:
>>> On 17/01/2024 10:37, Tim Lunn wrote:
>>>>> You can drop the description.
>>>> Yes just 1 clock, i will fix this.
>>>>>> +
>>>>>> + clock-names:
>>>>>> + description:
>>>>>> + The clock name for the codec clock.
>>>>> Drop.
>>>> Just drop the description? I dont think can drop the clock names as the
>>>> driver use the name to lookup clock:
>>> Description. But anyway the problem is that adding clocks should be
>>> separate patch with its own explanation.
>>>
>> Right, but I am not actually adding any clocks, just documenting what is
>> already there.
> You are. Binding did not have any clocks, now it has.
Ok, I will split the clocks into a separate patch.
>
>> There are already boards using this codec with rk809 in dts files and is
>> working fine from driver side.
>
>
> Best regards,
> Krzysztof
>
Powered by blists - more mailing lists