linux-kernel - Re: [PATCH] ASoC: soc-core.c: Add "Unknown" and "Unknown Product" to dmi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <473c1c2b-3426-4ec7-8319-dd08f3ae5a0c@perex.cz>
Date: Wed, 17 Jan 2024 13:20:09 +0100
From: Jaroslav Kysela <perex@...ex.cz>
To: Daniel Abrecht <linux-sound@...marc.danielabrecht.ch>,
 Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 Takashi Iwai <tiwai@...e.com>, linux-sound@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: soc-core.c: Add "Unknown" and "Unknown Product" to
 dmi_blacklist

On 17. 01. 24 13:14, Daniel Abrecht wrote:
> In U-Boot, the default for DMI vendor / product if not set is "Unknown"
> and "Unknown Product".
> See
> https://source.denx.de/u-boot/u-boot/-/blob/v2023.10/lib/smbios.c?ref_type=tags#L272
> 
> This patch adds them to the dmi_blacklist.
> 
> Signed-off-by: Daniel Abrecht <public@...ielabrecht.ch>

I think that there's a whitespace issue, but for the contents:

Acked-by: Jaroslav Kysela <perex@...ex.cz>


> ---
>    sound/soc/soc-core.c | 2 ++
>    1 file changed, 2 insertions(+)
> 
> diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
> index f8524b5bfb33..aa1a31abbe3a 100644
> --- a/sound/soc/soc-core.c
> +++ b/sound/soc/soc-core.c
> @@ -1804,6 +1804,8 @@ static const char * const dmi_blacklist[] = {
>        "Board Manufacturer",
>        "Board Vendor Name",
>        "Board Product Name",
> +    "Unknown",
> +    "Unknown Product",
>        NULL,    /* terminator */
>    };
> 

-- 
Jaroslav Kysela <perex@...ex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.