linux-kernel - Re: [PATCH v7 06/12] soc: qcom: Add Qualcomm APSS minidump kernel driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <510441c7-5a64-aaee-cafc-69bef2570da5@quicinc.com>
Date: Wed, 17 Jan 2024 18:05:58 +0530
From: Mukesh Ojha <quic_mojha@...cinc.com>
To: Randy Dunlap <rdunlap@...radead.org>, <corbet@....net>,
        <andersson@...nel.org>, <konrad.dybcio@...aro.org>,
        <robh+dt@...nel.org>, <krzysztof.kozlowski+dt@...aro.org>,
        <conor+dt@...nel.org>, <keescook@...omium.org>, <tony.luck@...el.com>,
        <gpiccoli@...lia.com>, <mathieu.poirier@...aro.org>, <vigneshr@...com>,
        <nm@...com>, <matthias.bgg@...il.com>, <kgene@...nel.org>,
        <alim.akhtar@...sung.com>, <bmasney@...hat.com>
CC: <linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v7 06/12] soc: qcom: Add Qualcomm APSS minidump kernel
 driver

Thanks for review.

On 1/10/2024 3:48 AM, Randy Dunlap wrote:
> Hi--
> 
> On 1/9/24 07:31, Mukesh Ojha wrote:
>> diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
>> index 1f81746131fc..56bc0c8a19f9 100644
>> --- a/drivers/soc/qcom/Kconfig
>> +++ b/drivers/soc/qcom/Kconfig
>> @@ -278,4 +278,17 @@ config QCOM_RPROC_MINIDUMP
>>   	  query predefined minidump segments associated with the remote processor
>>   	  and check its validity and end up collecting the dump on remote processor
>>   	  crash during its recovery.
>> +
>> +config QCOM_MINIDUMP
>> +	tristate "QCOM APSS Minidump driver"
>> +	depends on ARCH_QCOM || COMPILE_TEST
>> +	depends on QCOM_SMEM
>> +	help
>> +	  This config enables linux core infrastructure for Application
> 
> 	                      Linux
> same as 2 lines below.
> 
>> +	  processor subsystem (APSS) minidump collection i.e, it enables
> 
> 	                                      collection, i.e., it enables
> 
>> +	  Linux clients drivers to register their internal data structures
> 
> 	        client drivers
> 
>> +	  and debug messages as part of the apss minidump table and when
> 
> 	                                    APSS
> as above and in Subject.
> 
>> +	  the SoC is crashed, these selective regions will be dumped
> 
> 	          has
> 
>> +	  instead of the entire DDR dump. This saves significant amount
> 
> 	                                  This saves a significant amount
> 
> Does it have to be DDR?

Noted, all the above points, Yes DDR, I should perhaps use RAM like i
did it in the Doc.

-Mukesh

> 
> 
>> +	  of time and/or storage space.
>>   endmenu
>