linux-kernel - Re: [PATCH AUTOSEL 6.7 043/108] net: mvmdio: Avoid excessive sleeps in polled mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <824aec45-e474-455e-b2c6-00e618445c71@lunn.ch>
Date: Wed, 17 Jan 2024 02:54:50 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Sasha Levin <sashal@...nel.org>, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org, Tobias Waldekranz <tobias@...dekranz.com>,
	davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
	horms@...nel.org, krzysztof.kozlowski@...aro.org, robh@...nel.org,
	u.kleine-koenig@...gutronix.de, netdev@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 6.7 043/108] net: mvmdio: Avoid excessive sleeps
 in polled mode

On Tue, Jan 16, 2024 at 05:42:26PM -0800, Jakub Kicinski wrote:
> On Tue, 16 Jan 2024 14:39:09 -0500 Sasha Levin wrote:
> > Signed-off-by: Tobias Waldekranz <tobias@...dekranz.com>
> > Reviewed-by: Andrew Lunn <andrew@...n.ch>
> 
> Andrew and Tobias can override, but vote to drop this.
> Timing changes can backfire easily on flaky HW.

It was not intended for stable. It does not have a fixes tag, it was
not Cc: to stable, etc. Its just an optimisation.  So i agree with
Jakub, this should be dropped.

       Andrew