linux-kernel - Re: [PATCH] drivers: watchdog: Add ChromeOS EC watchdog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c7ddec3b-2304-4d7f-80da-0074c1d68cc0@kernel.org>
Date: Wed, 17 Jan 2024 16:29:52 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Lukasz Majczak <lma@...omium.org>, Gwendal Grignou
 <gwendal@...omium.org>, Lee Jones <lee@...nel.org>,
 Benson Leung <bleung@...omium.org>, Wim Van Sebroeck
 <wim@...ux-watchdog.org>, Tzung-Bi Shih <tzungbi@...nel.org>,
 Radoslaw Biernacki <biernacki@...gle.com>
Cc: linux-kernel@...r.kernel.org, chrome-platform@...ts.linux.dev,
 linux-watchdog@...r.kernel.org
Subject: Re: [PATCH] drivers: watchdog: Add ChromeOS EC watchdog

On 17/01/2024 11:24, Lukasz Majczak wrote:

Few more nits:

> This adds EC-based watchdog support for ChromeOS

Please do not use "This commit/patch/change", but imperative mood. See
longer explanation here:
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95

> based devices equipped with embedded controller (EC).
> 

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching.

And not a nit - important:

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC (and consider --no-git-fallback argument). It might
happen, that command when run on an older kernel, gives you outdated
entries. Therefore please be sure you base your patches on recent Linux
kernel.

Tools are doing it automatically, so either you work on some ancient
tree (don't), on fork of kernel (don't) or ignore some maintainers
(really don't).

Best regards,
Krzysztof